Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify limit_length() for infinite vectors #100204

Merged
merged 1 commit into from
Dec 11, 2024

Conversation

KoBeWi
Copy link
Member

@KoBeWi KoBeWi commented Dec 9, 2024

Closes #29714

The issue also mentions problems with multiplying, but you can't multiply infinity and 0, so the result makes sense. For limit_length() it's not obvious if you don't know the implementation.

@KoBeWi KoBeWi added this to the 4.4 milestone Dec 9, 2024
@KoBeWi KoBeWi requested a review from a team as a code owner December 9, 2024 14:32
Copy link
Member

@AThousandShips AThousandShips left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@Repiteo Repiteo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Having explicitly undefined behavior feels a bit at-odds with the rest of the engine, but if we're keeping the scope to documentation then I can't complain

@Repiteo Repiteo merged commit dee79d5 into godotengine:master Dec 11, 2024
20 checks passed
@Repiteo
Copy link
Contributor

Repiteo commented Dec 11, 2024

Thanks!

@KoBeWi KoBeWi deleted the nananananan branch December 11, 2024 23:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Vector2.clamped doesn't handle INFs
3 participants