Improve thread-safety of pipeline hash map. #100213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DarioSamo
force-pushed
the
pipeline-hash-map-thread-safety
branch
from
88d4ac5 to
be1dce1
Compare
RandomShaper
approved these changes
Dec 13, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pedro brought to my attention that there are possible race conditions concerning the hash map used by the pipeline cache for each material. This should ideally address any remaining race conditions and preserve the current level of performance, as
hash_mapis only intended to ever be accessed by the render thread and only rely on the mutex if a pipeline's missing to minimize the impact of the locking that is required.CC @RandomShaper