Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Codestyle] Merge identical code piece in ConvexHullComputer #100250

Merged
merged 1 commit into from
Dec 10, 2024

Conversation

YYF233333
Copy link
Contributor

This piece of code is duplicated 3 times for all 3 paths of the function. Merge them to make the code a bit more readable.

@YYF233333 YYF233333 requested a review from a team as a code owner December 10, 2024 17:25
@YYF233333 YYF233333 changed the title [Codestyle] Merge identical code piece. [Codestyle] Merge identical code piece Dec 10, 2024
@AThousandShips AThousandShips added this to the 4.x milestone Dec 10, 2024
@akien-mga akien-mga changed the title [Codestyle] Merge identical code piece [Codestyle] Merge identical code piece in ConvexHullComputer Dec 10, 2024
@akien-mga akien-mga modified the milestones: 4.x, 4.4 Dec 10, 2024
@Repiteo Repiteo merged commit 2e7f5f1 into godotengine:master Dec 10, 2024
20 checks passed
@Repiteo
Copy link
Contributor

Repiteo commented Dec 10, 2024

Thanks!

@YYF233333 YYF233333 deleted the style branch December 10, 2024 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants