Prevent using boolean varyings in vertex function of visual shaders #100309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chaosus
force-pushed
the
vs_prevent_invalid_boolean_varying
branch
from
9a2dd87 to
059ed73
Compare
paddy-exe
approved these changes
Jan 13, 2025
There was a problem hiding this comment.
Changes make sense.
From the Khronos OpenGL shading language PDF:
The varying qualifier can be used only with the data types float, vec2, vec3, vec4, mat2, mat3, and
mat4, or arrays of these. Structures cannot be varying.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevents user to write boolean varying with
Vertex -> [Fragment, Light]mode, which lead to shader compilation error.