Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix 3D ruler theme overrides #100312

Merged
merged 1 commit into from
Dec 12, 2024
Merged

Fix 3D ruler theme overrides #100312

merged 1 commit into from
Dec 12, 2024

Conversation

KoBeWi
Copy link
Member

@KoBeWi KoBeWi commented Dec 12, 2024

Fixes warning introduced in #100162

WARNING: Attempting to access theme items too early in Node3DEditorViewport; prefer NOTIFICATION_POSTINITIALIZE and NOTIFICATION_THEME_CHANGED
     at: get_theme_font (./scene/gui/control.cpp:2632)

@KoBeWi KoBeWi added this to the 4.4 milestone Dec 12, 2024
@KoBeWi KoBeWi requested a review from a team as a code owner December 12, 2024 12:15
@akien-mga akien-mga merged commit 0994736 into godotengine:master Dec 12, 2024
20 checks passed
@akien-mga
Copy link
Member

Thanks!

@KoBeWi KoBeWi deleted the rule_out_ruler_warnings branch December 12, 2024 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akien-mga akien-mga

Assignees
No one assigned
Labels
bug topic:editor topic:gui topic:3d
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.
2 participants
@KoBeWi @akien-mga