Consolidate RenderingDeviceDriver's VectorView into Span.
#100338
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Closing for now since it may actually make sense to allow implicit conversions just this once. May revisit the idea after the Span PR is actually merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on, and includes, #100293. Draft until it is finalized and merged.
This removes RenderingDeviceDriver's own
VectorViewstruct in favour of core'sSpan.It may have been somewhat easier to merge the two, had
VectorViewnot chosen to utilize implicit conversions. Implicit conversions will break your neck because you will sooner or later run into ambiguous calls and / or unwanted conversions. Better to address it now than later. I had tried to do it withSpanas well, but very soon ran into issues because of overload clashes inString.Other than that, the migration was fairly uneventful.