Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 3D CSG not reacting to child node order changes #100340

Merged
merged 1 commit into from
Dec 13, 2024
+4 −0
Merged

Fix 3D CSG not reacting to child node order changes #100340

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions modules/csg/csg_shape.cpp
View file
Original file line number Diff line number Diff line change
@@ -848,6 +848,10 @@ void CSGShape3D::_notification(int p_what) {
parent_shape = nullptr;
} break;

case NOTIFICATION_CHILD_ORDER_CHANGED: {
_make_dirty();
} break;

case NOTIFICATION_VISIBILITY_CHANGED: {
if (!is_root_shape() && last_visible != is_visible()) {
// Update this node's parent only if its own visibility has changed, not the visibility of parent nodes