Make RID allocation thread-safe when using Jolt Physics
#100342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mihe
changed the title
RID allocation thread-safe when using Jolt Physics
akien-mga
approved these changes
Dec 13, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that I had missed the fact that Godot's
RID_PtrOwnerwasn't thread-safe by default, and as a result the experimental thread-safety when using the Jolt physics server wasn't so safe after all. This is because RID-allocating methods (e.g.box_shape_create) are called directly regardless of thread, as opposed to being queued up in the command buffer ofPhysicsServer3DWrapMT, so anything done within them must be thread-safe.This PR resolves this by simply enabling the thread-safety of all
RID_PtrOwnerused inJoltPhysicsServer3D.(Thanks to @Zylann for pointing this out!)