Small fixups for the new reflection probe blending #100344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes some small issues from #99958
The biggest issue is that ANGLE doesn't allow mixing ints and floats so this shader will fail to compile on the web or when using the ANGLE backend.
Second, the way the shader is written it does a lot of unnecessary instructions. Running a quick comparison in shader playground shows that it was allocating 2 more VGPRs than necessary and was roughly doing double the number of instructions it needed to. https://shader-playground.timjones.io/0a125912ec8d14f234b4a9c287f0f2e6
I rewrote the code to do vector operations throughout (the compiler mostly did this, but not fully) and avoid doing work that would get immediately undone. This makes the code easier to understand, faster to compile, and faster to run.