Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove solid boxes in gizmos of VoxelGI and ReflectionProbe #100370

Merged

Conversation

lander-vr
Copy link
Contributor

@lander-vr lander-vr commented Dec 13, 2024

Removes the solid boxes in the gizmos of VoxelGI and ReflectionProbes for improved visibility.

This is definitely a tradeoff since their scale and positioning is less obvious now, especially for ReflectionProbes, however the solid box is extremely intrusive. It requires users to move their view inside of the probe, or constantly toggle gizmos, which is really cumbersome. You can't get a decent view of how the probe is sitting in the environment and what effect your adjustments have. You're either only seeing whatever is outside the probe or whatever is inside.

An additional issue with the boxes is that their amount of obstructing differs from scene to scene, in some scenes the opacity is very low, while in other scenes it prevents you from seeing what's happening inside the bounds.

In the same vein, I've slightly reduced the opacity of the VoxelGI gridlines, since they're mostly just an indication of voxel size, and are (still) very obstructive.

In an ideal world we would be able to show the solid boxes only when the size is being adjusted, but (I believe) there's no way at the moment to detect whether or not a handle is grabbed in the gizmo, and then there's also the question of how that behavior would combine with adjustments done in the inspector.

This solution is not ideal, but I'd argue the lesser of two evils for now.

PR Master
image image
image image
image image
image image

@akien-mga akien-mga modified the milestones: 4.x, 4.4 Dec 21, 2024
@akien-mga akien-mga merged commit 6f2f909 into godotengine:master Dec 21, 2024
20 checks passed
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants