Remove solid boxes in gizmos of VoxelGI and ReflectionProbe #100370
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and Adjust VoxelGI gizmo opacity #99969.
Removes the solid boxes in the gizmos of VoxelGI and ReflectionProbes for improved visibility.
This is definitely a tradeoff since their scale and positioning is less obvious now, especially for ReflectionProbes, however the solid box is extremely intrusive. It requires users to move their view inside of the probe, or constantly toggle gizmos, which is really cumbersome. You can't get a decent view of how the probe is sitting in the environment and what effect your adjustments have. You're either only seeing whatever is outside the probe or whatever is inside.
An additional issue with the boxes is that their amount of obstructing differs from scene to scene, in some scenes the opacity is very low, while in other scenes it prevents you from seeing what's happening inside the bounds.
In the same vein, I've slightly reduced the opacity of the VoxelGI gridlines, since they're mostly just an indication of voxel size, and are (still) very obstructive.
In an ideal world we would be able to show the solid boxes only when the size is being adjusted, but (I believe) there's no way at the moment to detect whether or not a handle is grabbed in the gizmo, and then there's also the question of how that behavior would combine with adjustments done in the inspector.
This solution is not ideal, but I'd argue the lesser of two evils for now.