Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Sync in BlendSpace1D/2D with BlendModeDiscrete #100373

Merged
merged 1 commit into from
Dec 17, 2024
Merged

Fix Sync in BlendSpace1D/2D with BlendModeDiscrete #100373

merged 1 commit into from
Dec 17, 2024

Conversation

TokageItLab
Copy link
Member

Fixed a problem with Discrete not DiscreteCarry where the current time was not propagated from p_playback_info to from and was always zero.

@TokageItLab TokageItLab added bug topic:animation cherrypick:4.3 Considered for cherry-picking into a future 4.3.x release labels Dec 13, 2024
@TokageItLab TokageItLab added this to the 4.4 milestone Dec 13, 2024
@TokageItLab TokageItLab requested a review from a team as a code owner December 13, 2024 17:45
@TokageItLab TokageItLab mentioned this pull request Dec 13, 2024
Closed
@TokageItLab TokageItLab changed the title Fix Sync in BlendSpace1d/2D with BlendModeDiscrete Fix Sync in BlendSpace1D/2D with BlendModeDiscrete Dec 14, 2024
@TokageItLab TokageItLab force-pushed the fix-blendspace-discrete-sync branch from 4db31ab to d54229d Compare December 14, 2024 04:00
fire
fire approved these changes Dec 17, 2024
View reviewed changes
Copy link
Member

@fire fire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did a scan, but my understanding of the problem is fuzzy. This looks good to me.

@akien-mga akien-mga merged commit 382b0df into godotengine:master Dec 17, 2024
20 checks passed
@akien-mga
Copy link
Member

Thanks!

@Spartan322 Spartan322 mentioned this pull request Jan 23, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fire fire fire approved these changes

@akien-mga akien-mga akien-mga approved these changes

Assignees
No one assigned
Labels
bug cherrypick:4.3 Considered for cherry-picking into a future 4.3.x release topic:animation
Projects
Animation Team Issue Triage
Status: Done
Milestone
4.4
Development

Successfully merging this pull request may close these issues.

BlendSpace2D Sync does not work with BlendModeDiscrete
3 participants
@TokageItLab @akien-mga @fire