Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude known thirdparty/ ubsan errors #100380

Merged
merged 1 commit into from
Dec 13, 2024

Conversation

hpvb
Copy link
Member

@hpvb hpvb commented Dec 13, 2024

In my quest to make ubsan failures a build failure I've added all current ubsan errors by type to a new suppression file which we will then also use with CI.

The idea is to only add known ubsan errors to this file, so this is not a blanket exclusion of thirdparty/ this means that if we get new or unexpected ubsan in thirdparty/ builds would fail.

@hpvb hpvb added this to the 4.4 milestone Dec 13, 2024
@hpvb hpvb requested a review from a team as a code owner December 13, 2024 21:52
In my quest to make ubsan failures a build failure I've added all
current ubsan errors by type to a new suppression file which we will
then also use with CI.

The idea is to only add known ubsan errors to this file, so this is not
a blanket exclusion of thirdparty/ this means that if we get new or
unexpected ubsan in thirdparty/ builds would fail.
@Repiteo Repiteo merged commit 3e3a013 into godotengine:master Dec 13, 2024
20 checks passed
@Repiteo
Copy link
Contributor

Repiteo commented Dec 13, 2024

Thanks!

@hpvb hpvb deleted the thirdparty-ubsan branch December 13, 2024 22:52
@WhalesState
Copy link
Contributor

WhalesState commented Mar 20, 2025

Is this the reason why github actions fails to run the test project in master?

image

UndefinedBehaviorSanitizer: failed to read suppressions file '/home/runner/work/godot/godot/bin/misc/error_suppressions/ubsan.txt'

@akien-mga
Copy link
Member

I don't think those are failures, the test projects still run fine I believe.
But yes the suppressions don't seem to work, there's a mismatch between the relative path used and how it's resolved from the binary itself.

@WhalesState
Copy link
Contributor

WhalesState commented Mar 20, 2025

This seems to fix it in linux_builds.yml.

  TSAN_OPTIONS: suppressions=${{ github.workspace }}/misc/error_suppressions/tsan.txt
  UBSAN_OPTIONS: suppressions=${{ github.workspace }}/misc/error_suppressions/ubsan.txt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants