Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.x] Enable builds with miniupnpc API 18 #100389

Merged
merged 1 commit into from
Jan 22, 2025
Merged

Conversation

twrightsman
Copy link
Contributor

Backports #97139 without bumping the embedded miniupnpc library.

I recognize that the maintainers typically cherry-pick in batches, but since #97139 was not marked for cherry-picking to 3.x I figured I would manually do it.

This is to get Godot 3.6 packaged in Debian, which is on miniupnpc 2.2.8 (API 18).

Backports godotengine#97139 without
bumping the embedded miniupnpc library.

Co-authored-by: Rémi Verschelde <rverschelde@gmail.com>
@twrightsman twrightsman requested a review from a team as a code owner December 14, 2024 04:56
@AThousandShips AThousandShips changed the title Enable builds with miniupnpc API 18 [3.x] Enable builds with miniupnpc API 18 Dec 14, 2024
@AThousandShips AThousandShips added this to the 3.7 milestone Dec 14, 2024
Copy link
Member

@lawnjelly lawnjelly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks similar to master.

@lawnjelly lawnjelly merged commit 5e904cd into godotengine:3.x Jan 22, 2025
14 checks passed
@lawnjelly
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants