Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve UID support for main scene #100408

Merged
merged 1 commit into from
Dec 17, 2024
Merged

Conversation

KoBeWi
Copy link
Member

@KoBeWi KoBeWi commented Dec 14, 2024

Makes all code paths (the FileSystem dock option and EditorNode when running without scene) set main scene as UID instead of paths. Also makes main scene properly highlighted in FileSystem when it's UID.

EDIT:
Also included bugfix for loading scenes by UID.
Fixes #100354

@KoBeWi KoBeWi added this to the 4.4 milestone Dec 14, 2024
@KoBeWi KoBeWi requested a review from a team as a code owner December 14, 2024 19:03
@KoBeWi KoBeWi requested a review from a team as a code owner December 16, 2024 18:58
@KoBeWi
Copy link
Member Author

KoBeWi commented Dec 16, 2024

Added a fix for #100354

@akien-mga akien-mga merged commit e237dd0 into godotengine:master Dec 17, 2024
20 checks passed
@akien-mga
Copy link
Member

Thanks!

@KoBeWi KoBeWi deleted the pathdoom branch December 17, 2024 15:46
@matheusmdx
Copy link
Contributor

This should fix #100084 that looks the same issue as #100354

@BastiaanOlij
Copy link
Contributor

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Exported project fails to start when UID is saved in project settings
4 participants