Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix origin being included in per viewport grid visibility toggle, and add ability to hide it seperately #100435

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ryevdokimov
Copy link
Contributor

@ryevdokimov ryevdokimov commented Dec 15, 2024

#88584 added the ability to hide the grid per viewport, but accidentally included the origin, which is technically a bug. This PR separates them out, and now both can be toggled.

2025-02-08.12-52-18.mp4

@aaronfranke
Copy link
Member

When the origin is not drawn, the grid lines are supposed to be drawn in its place.

@ryevdokimov ryevdokimov force-pushed the hide-origin-per-viewport branch from 9c387dc to 42fef1d Compare February 8, 2025 08:23
@ryevdokimov
Copy link
Contributor Author

When the origin is not drawn, the grid lines are supposed to be drawn in its place.

Good catch, I modified the code so that the origin lines have a higher render priority so that they are always on top of the grid lines and removed the need to have to rebuild the grid.

@ryevdokimov ryevdokimov force-pushed the hide-origin-per-viewport branch from 42fef1d to 6a9b5ae Compare February 8, 2025 08:47
@badsectoracula
Copy link
Contributor

The PR seems to work as expected, but IMO this is more of a new feature than a bug fix - since essentially it adds the option to toggle the grid and origin separately, adding to the UI of an already overloaded menu - so i think it is a good idea to make a feature suggestion for this and link this PR from it.

@ryevdokimov
Copy link
Contributor Author

ryevdokimov commented Feb 13, 2025

There is a proposal linked above that effectively covers that godotengine/godot-proposals#11363. I agree as well that the menu is overloaded, but I do believe there is another proposal to clean that up.

Edit: Found it: godotengine/godot-proposals#11256

@Repiteo Repiteo modified the milestones: 4.4, 4.5 Feb 24, 2025
@ryevdokimov ryevdokimov force-pushed the hide-origin-per-viewport branch from 6a9b5ae to 618a100 Compare March 12, 2025 00:00
@ryevdokimov ryevdokimov force-pushed the hide-origin-per-viewport branch from 618a100 to cac358c Compare March 12, 2025 00:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants