Abstract CowData's reallocations into _realloc to consolidate duplicate logic.
#100474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hpvb
reviewed
Dec 18, 2024
hpvb
reviewed
Dec 18, 2024
Ivorforce
force-pushed
the
cowdata-abstract-realloc
branch
from
1528815 to
8483d79
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One can see that both code blocks were the same. The logic may further be used in the future to optimize other
CowDatafunctions that grow or shrink the array for various reasons.The current refcount returned by
copy_on_writeis guaranteed to be 1 in cases wherereallocis called (i.e. an array exists, and we've forked off already). Therefore, it is safe to just init refcount with1.