Fix RichTextLabel bbcode rainbow play reversed and paused
#100494
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AThousandShips
added
bug
topic:gui
cherrypick:4.2
bruvzg
approved these changes
Dec 18, 2024
bruvzg
reviewed
Dec 18, 2024
| @@ -716,7 +717,7 @@ class RichTextLabel : public Control { | |||
| void push_shake(int p_strength, float p_rate, bool p_connected); | |||
| void push_wave(float p_frequency, float p_amplitude, bool p_connected); | |||
| void push_tornado(float p_frequency, float p_radius, bool p_connected); | |||
| void push_rainbow(float p_saturation, float p_value, float p_frequency); | |||
| void push_rainbow(float p_saturation, float p_value, float p_frequency, float p_speed); | |||
There was a problem hiding this comment.
Note: method isn't exposed, so no need for compatibility bind.
|
Thanks! |
akien-mga
removed
the
cherrypick:4.2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the abillity to pause and reverse the bbcode
rainbowanimation as written in the documentation (bbcode_in_richtextlabel)Adds a new bbcode option:
speed- a negative value will play the animation reversed, a positive value will play the animation forwards, and a value of0will pause the animationI have added the argument
speedso that it is possible to change the speed independently of the frequency.Fixes #85031