-
-
Notifications
You must be signed in to change notification settings - Fork 21.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
KTX: Add support for loading most ETC-compressed formats #100524
Conversation
I'm not sure how to review this, but I would like to. |
This can be tested simply by importing the attached images into the editor. On mobile hardware the images will be created directly from the data and passed to the GPU. On desktop the process will be the same except they will be decompressed when RenderingDevice/OpenGL try to create them on the GPU. For comparison purposes the .ktx files can be decompressed with command line tools such as https://github.com/google/etc2comp |
/*case GL_COMPRESSED_SIGNED_R11_EAC: | ||
format = Image::FORMAT_ETC2_R11S; | ||
break; | ||
break;*/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd add a comment to describe why this is commented out (most likely because etcpak doesn't support it?).
Same for other commented out blocks below.
6bef1fe
to
6f02846
Compare
864727c
to
5dbd279
Compare
The gui-nodes review request isn't required btw, I accidentally rebased this on top of something else |
Thanks! |
Follow-up to #100365
Adds support for loading KTX files compressed into ETC, ETC2_RGB, ETC2_RGBA8, ETC2_R11 and ETC2_RG11 formats. This now works since the engine has a dedicated decompression utility for them.
Some sample files for testing: ktx.zip