Support custom sky rotation in SDFGI #100544
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Namey5
force-pushed
the
sdfgi-sky-rotation
branch
from
6749e5d to
f7d9dcd
Compare
clayjohn
reviewed
Dec 19, 2024
Namey5
force-pushed
the
sdfgi-sky-rotation
branch
from
f7d9dcd to
c22e018
Compare
clayjohn
approved these changes
Dec 19, 2024
Namey5
force-pushed
the
sdfgi-sky-rotation
branch
from
c22e018 to
c13dc52
Compare
Namey5
force-pushed
the
sdfgi-sky-rotation
branch
from
c13dc52 to
e4fd2f0
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Custom sky rotation was not factored into SDFGI integration.
I've encoded the rotation as a quaternion into unused bits of existing sky push-constants - accuracy of reconstruction could be improved (I've gone for the simplest method), but I'm not sure there would be a noticeable benefit from doing so in this case.
Before:
After:
Reference (VoxelGI):
GPU performance is equivalent on my 3080Ti ~(0.06ms-0.07ms for both).
Before:
After:
Fixes #62793