Fix initialization order in AudioStreamInteractive to allow initial_clip to be properly played
#100552
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdelorme
changed the title
AudioStreamInteractive to allow initial_clip to be properly played
akien-mga
changed the title
AudioStreamInteractive to allow initial_clip to be properly playedAudioStreamInteractive to allow initial_clip to be properly played
akien-mga
reviewed
Dec 18, 2024
akien-mga
added
the
cherrypick:4.3
|
Looks good! Could you squash the commits? See PR workflow for instructions. |
mdelorme
force-pushed
the
mdelorme/issue_100514
branch
from
00e6fad to
193fccf
Compare
|
I think I messed up and included another commit in the PR. Lemme fix that. Sorry |
mdelorme
force-pushed
the
mdelorme/issue_100514
branch
from
193fccf to
95ff87d
Compare
|
All good now |
akien-mga
approved these changes
Dec 18, 2024
|
Sorry for that, am I the one supposed to fix this or can the formatting changes be approved by a maintainer ? |
|
You need to do the formatting fixes yourself ideally. You'd do it by removing the trailing tab on the line flagged in the diff: https://github.com/godotengine/godot/actions/runs/12394304279/job/34597974426?pr=100552 And then amend the commit and force push to udpate the PR, keeping a single commit. |
mdelorme
force-pushed
the
mdelorme/issue_100514
branch
from
95ff87d to
ea97d44
Compare
|
Ok ! Thank you very much for the guidance :) |
|
Thanks! And congrats for your first merged Godot contribution 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #100514
Problem comes from the initialization order of
initial_clipcoming before the actual clips. When theAudioStreamInteractiveis loaded in the scene, no clips are loaded yet.initial_clipis reset to 0 triggering the error. Then the clips are loaded, and theinitial_clipwill inevitably become the first of the list.I propose a fix by simply changing the order of the two properties in the class. Having the
initial_clipbeing declared after the actual clips, fixes everything.