Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TextServer] Fix use of find_char in text servers #100562

Merged
merged 1 commit into from
Dec 20, 2024

Conversation

AThousandShips
Copy link
Member

@AThousandShips AThousandShips commented Dec 18, 2024

The find_char method is not (currently) available to extensions and
can't be used in the text servers which can be built as extensions, so
now controlled by compile option

I missed this when reviewing #100024

@AThousandShips AThousandShips changed the title [TextServer] Restore find in text servers [TextServer] Fix use of find_char in text servers Dec 18, 2024
@Repiteo
Copy link
Contributor

Repiteo commented Dec 20, 2024

Needs to be rebased before this can be merged

@AThousandShips
Copy link
Member Author

I'll rebase shortly!

The `find_char` method is not (currently) available to extensions and
can't be used in the text servers which can be built as extensions, so
now controlled by compile option
@akien-mga akien-mga merged commit e91b3ec into godotengine:master Dec 20, 2024
20 checks passed
@akien-mga
Copy link
Member

Thanks!

@AThousandShips AThousandShips deleted the fix_text_server_binds branch December 21, 2024 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants