Remove unused headers in core #100564
Remove unused headers in core #100564
Conversation
|
Seems like https://github.com/godotengine/godot/actions/runs/12396780139/job/34605644487?pr=100564 requires |
|
Thanks! |
| @@ -42,8 +42,6 @@ | |||
| #include "core/templates/safe_refcount.h" | |||
| #include "core/typedefs.h" | |||
|
|
|||
| #include <new> | |||
There was a problem hiding this comment.
FYI, this was actually needed and caused a crash with GCC 12: #100768 (fixed in #101004).
This was a honest mistake but shows we need to be somewhat cautious when reviewing IWYU suggestions.
I'm still unsure why IWYU would consider it unused when it's used below, but I suspect it's a matter of #if conditions not matching. On some platforms (MSVC) this <new> would indeed be unused, while it's used for GCC (and presumably Clang).
So we need to be careful there too that some "global" includes might actually be needed for a code branch that's not compiled on the current platform used with IWYU. Normally CI should catch it and fail compiling, but in this case it didn't (I don't know why it compiles but then crashes).
| @@ -31,8 +31,6 @@ | |||
| #ifndef THREAD_SAFE_H | |||
| #define THREAD_SAFE_H | |||
|
|
|||
| #include "core/os/mutex.h" | |||
There was a problem hiding this comment.
This was also a wrong suggestion from IWYU, as it's used just below in macros. Apparently it doesn't support macros, so we need to be cautious there too when reviewing changes.
Trying to apply include-what-you-use to godot codebase, but turns out it is not smart enough for such complex dependency graph, so I pick some safe changes and applied manually.
Hopefully this will reduce build time a bit. (and also warnings in your IDE) 😄