C#: Add option to treat warnings as errors #100568
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With CI now able to detect warnings/errors from MSBuild operations, the ability to outright fail a CI if such warnings/errors crop up has become much more important. This integrates exactly that, by adding a new argument
--werror
to the monobuild_assemblies.py
, which functions likewerror=yes
on SCons. This argument is now passed in the Linux mono CI, and the two existing warnings have been addressed so builds will succeed.