Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C#: Add option to treat warnings as errors #100568

Merged
merged 1 commit into from
Dec 18, 2024

Conversation

Repiteo
Copy link
Contributor

@Repiteo Repiteo commented Dec 18, 2024

With CI now able to detect warnings/errors from MSBuild operations, the ability to outright fail a CI if such warnings/errors crop up has become much more important. This integrates exactly that, by adding a new argument --werror to the mono build_assemblies.py, which functions like werror=yes on SCons. This argument is now passed in the Linux mono CI, and the two existing warnings have been addressed so builds will succeed.

Copy link
Member

@raulsntos raulsntos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks! I tested it locally and works as expected, I'll be passing --werror in my build scripts so I don't miss new warnings when testing PRs from now on.

@akien-mga akien-mga merged commit 024efda into godotengine:master Dec 18, 2024
20 checks passed
@akien-mga
Copy link
Member

Thanks!

@Repiteo Repiteo deleted the dotnet/warning-as-error branch December 30, 2024 02:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants