Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GDScript] Fix Packed*Array OP_IN using low precision int and float as input. #100582

Merged
merged 1 commit into from
Dec 20, 2024
Merged

[GDScript] Fix Packed*Array OP_IN using low precision int and float as input. #100582

merged 1 commit into from
Dec 20, 2024

Conversation

bruvzg
Copy link
Member

@bruvzg bruvzg commented Dec 18, 2024

Fixes #100580

@bruvzg bruvzg added this to the 4.4 milestone Dec 18, 2024
@bruvzg bruvzg requested a review from a team as a code owner December 18, 2024 21:42
Mickeon
Mickeon approved these changes Dec 18, 2024
View reviewed changes
Copy link
Contributor

@Mickeon Mickeon left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like the types were written under the assumption that C++'s types are the same as Variant's float and int types, whereas the latter are both 64 bits.

Should we... cherrypick this?

@akien-mga akien-mga added the cherrypick:4.3 Considered for cherry-picking into a future 4.3.x release label Dec 18, 2024
@Repiteo Repiteo merged commit fb8d2ee into godotengine:master Dec 20, 2024
20 checks passed
@Repiteo
Copy link
Contributor

Repiteo commented Dec 20, 2024

Thanks!

@Spartan322 Spartan322 mentioned this pull request Jan 22, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aaronfranke aaronfranke aaronfranke approved these changes

@akien-mga akien-mga akien-mga approved these changes

@Mickeon Mickeon Mickeon approved these changes

Assignees
No one assigned
Labels
bug cherrypick:4.3 Considered for cherry-picking into a future 4.3.x release topic:gdscript
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.

in operator for PackedInt64Array always returns false when operand > 2147483647 (max signed int32 value)
5 participants
@bruvzg @Repiteo @aaronfranke @akien-mga @Mickeon