Avoid allocating instance buffer for PointLight2D shadows when there are no instances #100612
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…are no instances. Also avoid the render loop if there are no occluders. We still have to open the render pass to do a clear though.
akien-mga
approved these changes
Dec 19, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #100609
The problem arises when shadows are enabled, but there are no occluders. The shadow rendering path tries to allocate a zero sized buffer which isn't allowed. The solution is to just not allocate the buffer when there are zero instances. That necessitates also skipping the render loop since we can't bind a buffer that doesn't exist. We still have to create the render pass though to clear the shadow atlas.