Rendering: MoltenVK hack is no longer required, as bug was fixed. #100653
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original issue: godotengine#51679 (comment) And related fix in SPIRV-Cross: KhronosGroup/SPIRV-Cross#2046
akien-mga
approved these changes
Dec 20, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This workaround is no longer required. The original reason was found here:
Original issue: #51679 (comment)
And related issue and fix in SPIRV-Cross: KhronosGroup/SPIRV-Cross#2046
I also confirmed that Vulkan on my MacBook Pro works fine without the workaround.