Tweak TextureProgressBar NOTIFICATION_DRAW to support 9-patch stretch in radial modes
#100697
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arkology
force-pushed
the
texture-progress-radial-stretching
branch
from
a7a2799 to
eb09fa3
Compare
KoBeWi
reviewed
Jan 12, 2025
KoBeWi
approved these changes
Jan 12, 2025
…etch in radial modes 1) Code is splitted into 3 sections: - draw `under` texture; - draw `progress` texture + draw radial modes reference cross; - draw `over` texture. Each draw texture section handles nine-patch stretching. Except for the progress texture in radial modes, which does not support nine-patch stretching. 2) The reference cross position now is not misaligned to real center position (`floor()` call removed). 3) The reference cross drawing code is additionally surrounded by `TOOLS_ENABLED` check.
arkology
force-pushed
the
texture-progress-radial-stretching
branch
from
eb09fa3 to
c46c3dd
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original reason for the changes - 9-patch stretching is ignored for
underandovertextures in radial modes.undertexture;progresstexture + draw radial modes reference cross;overtexture.Each draw texture section handles nine-patch stretching. Except for the progress texture in radial modes, which does not support nine-patch stretching (because it is not possible).
floor()call removed).TOOLS_ENABLEDcheck.Preview "before-after":
