Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android: Fix Window size changes ignored when node is not in tree #100746

Merged
merged 1 commit into from
Dec 23, 2024

Conversation

syntaxerror247
Copy link
Member

Fixes a regression from my PR (#99669) on Android where window size changes are ignored if the node is not in the tree.

Fixes #100743

Copy link
Contributor

@Sauermann Sauermann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Additionally checking for is_inside_tree() should correctly solve the reported bug. Haven't tested it though.

@Repiteo Repiteo merged commit a7fb67b into godotengine:master Dec 23, 2024
20 checks passed
@Repiteo
Copy link
Contributor

Repiteo commented Dec 23, 2024

Thanks!

@syntaxerror247 syntaxerror247 deleted the size-regression branch December 23, 2024 17:31
@Sauermann Sauermann added the cherrypick:4.3 Considered for cherry-picking into a future 4.3.x release label Dec 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug cherrypick:4.3 Considered for cherry-picking into a future 4.3.x release platform:android regression topic:gui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Window ignores size changes when not in tree (Android only)
5 participants