[Core] Align naming and args of (SceneTree)Timer time scale methods
#100752
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AThousandShips
force-pushed
the
unify_timer_scale_naming
branch
from
2d7aa99 to
3e094ae
Compare
|
I think this should include the |
|
That can't be done without breaking compatibility. It can be done here for Timer because it was just recently added in the dev builds. |
This method on I'd also personally be in support of renaming it on |
|
Will get that done too! Thank you |
AThousandShips
force-pushed
the
unify_timer_scale_naming
branch
from
3e094ae to
6bea00b
Compare
Renamed `get_ignore_time_scale` to `is_ignoring_time_scale` following general naming standards.
AThousandShips
force-pushed
the
unify_timer_scale_naming
branch
from
6bea00b to
8d1a3e2
Compare
AThousandShips
changed the title
Timer time scale methods(SceneTree)Timer time scale methods
Mickeon
approved these changes
Dec 24, 2024
|
Thanks! |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Renamed
get_ignore_time_scaletois_ignoring_time_scalefollowing general naming standards.See conversation in:
Engine.time_scale#100735Left the default argument as is, the
Tweencode is different in that regardDoesn't break compatibility as it was introduced during 4.4