OpenXR: Fix hiding/showing composition layers using hole punching #100763
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsnopek
added
the
cherrypick:4.3
m4gr3d
approved these changes
Dec 24, 2024
|
Thanks! |
|
Cherry-picked for 4.3.1. |
akien-mga
removed
the
cherrypick:4.3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, with a composition layer that uses hole punching, changing
visible(to hide/show the composition layer) won't have an effect most of the time.This is due to some old logic that is checking if the
fallbacknode exists or not to see if we are using real composition layers (versus a fallback for OpenXR runtimes that don't support them). However, after we added the hole punching feature (in #91485), this logic no longer makes sense, because we are using the fallback mesh to setup hole punching as well.So, this PR switches to checking
is_natively_supported()instead, which is working in my testing