Allow overriding SpinBox value on focus_exited
#100860
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #100836
When setting
SpinBox
's value the text is only updated onNOTIFICATION_DRAW
. If the value is changed on the same frame as the focus is lost, this means the old text will be submitted instead. This PR thus checks if the value has changed before submitting the text.With this PR the MRP will:
focus_exited
._val_changed()
when usingset_value_no_signal()
._val_changed()
once when directly settingvalue
.