Pre-commit: Fix applying ruff to SCsub files #100870
Merged
+8
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also ignore iOS template dummy.h file for header guards check. Update ruff to 0.8.4 while at it.
akien-mga
force-pushed
the
ci-fix-ruff-format
branch
from
629cfe7 to
ff83fdc
Compare
akien-mga
commented
Dec 28, 2024
Comment on lines
+57
to
+61
| files: (\.py|SConstruct|SCsub)$ | ||
| types_or: [text] | ||
| - id: ruff-format | ||
| files: (\.py|SConstruct|SCsub)$ | ||
| types_or: [text] |
There was a problem hiding this comment.
This is needed because pre-commit decides which files to run on before handling potential explicit includes in pyproject.toml, at least for me on Linux with pre-commit 4.0.1.
And since the default types: is only known Python file types, it doesn't include the SConstruct and SCsub files.
akien-mga
commented
Dec 28, 2024
| @@ -14,7 +14,7 @@ python_version = "3.8" | |||
|
|
|||
| [tool.ruff] | |||
| extend-exclude = ["thirdparty"] | |||
| extend-include = ["SConstruct", "SCsub"] | |||
| extend-include = ["*SConstruct", "*SCsub"] | |||
There was a problem hiding this comment.
Before:
$ ruff format
106 files left unchanged.
After:
277 files left unchanged.
(We have a couple nested SConstructs too in the TextServer modules for their GDExtension based builds.)
On the other hand the thirdparty extend-exclude without globbing pattern seems to work file to exclude both
./modules/mono/thirdparty
./thirdparty
according to debug logs. No idea why it differs here.
Repiteo
approved these changes
Dec 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also ignore iOS template dummy.h file for header guards check.
Update ruff to 0.8.4 while at it.