-
-
Notifications
You must be signed in to change notification settings - Fork 21.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix MSVC Variant Workaround #100904
Fix MSVC Variant Workaround #100904
Conversation
Thanks for addressing the issue! I can see it's a simple solution - apparently relying on implicit static casts instead of explicit conversions avoids the bug. Personally, i avoid implicit conversions because i think they make for code that is hard to understand. |
The amount of implicit conversions in the codebase is proooobably something that should be looked into eventually. A lot of subtle issues crop up from them, but I'm not certain if it's to the extent that it needs anything done about it |
Another thought; does this close #100605 or do we still want to report the bug to MSVC? |
If this gets merged, I think we should close #100605. However, that doesnt' mean people can not still try to reproduce the issue and report it to MSVC. I have a small godbolt link trying to reproduce the issue, but with no luck yet. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As mentioned above; I'm not super happy about the use of implicit conversions but it's definitely better than what we have now!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested locally (MSVC 2022 17.11.3), it works as expected.
Thanks! |
Fix this issue.