SCons: Properly NoCache all text files
#101008
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akien-mga
approved these changes
Jan 11, 2025
Repiteo
force-pushed
the
scons/nocache-all-text
branch
from
5ac55f5 to
73278bf
Compare
|
We've got some spurious errors in compile output in CI following this, see https://github.com/godotengine/godot/actions/runs/12819416963/job/35765666274#step:11:1959 Some cases completely overflow the log |
| print_error(f'Failed to remove cache file "{file}"; skipping.') | ||
| count -= 1 | ||
| if verbose: | ||
| print_info(f"Purged {count} file{'s' if count else ''} from cache.") |
There was a problem hiding this comment.
Identified the issue, the loop should break here, will write up a fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out, reading files in the cache becomes prohibitively slow once it achieves moderate size. Instead of attempting to optimize what was already a bandage solution, this tackles the root issue of text files being incorrectly cached.
NoCachewas never properly applied to several builders, most notably all.glsl.gen.hfiles, so this sweeps through and ensures they're actually enforced. Consequently, the dedicated text cache check has been entirely discarded; there's no reasonable situation where that will occur anymore, and the performance hit isn't worth it in the first place.