-
-
Notifications
You must be signed in to change notification settings - Fork 22k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[macOS/Windows] Add Emoji & Symbols
context menu item to LineEdit/TextEdit to show system character picker.
#101021
Conversation
Would look better with just emoji and then showing the shortcut like the others |
Added Windows support as well. |
Emoji & Symbols
context menu item to LineEdit/TextEdit to show system character picker.Emoji & Symbols
context menu item to LineEdit/TextEdit to show system character picker.
Keeping it at the top will screw up with the user's muscle memory so maybe it's worth evaluating to move it down. |
It's best at the top that's what's used by browsers since it's most accessible and acts as a second keyboard. |
It’s worth considering renaming "Emoji & Symbols" to just "Emoji" because all the other options are shorter, making this one stand out negatively due to its length. Additionally, "Emoji" is a more commonly used term for this action in browsers. |
Chromium based browsers have it on top, GTK have it on the bottom, macOS have it at the bottom of "Edit" menu. Not sure if there are any other examples for emoji picker in the context menu.
On macOS, Chromium also calls it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested locally on Windows 11 23H2, it works as expected.
One issue I noticed is that the dialog appears when right-clicking text fields that only accept numeric values, such as SpinBox and EditorSpinSlider (as shown above). Perhaps these fields should have a property not to show the emoji option in the context menu?
Since there isn't a standard for naming or placement, I suggest the following:
|
Is it possible to make this usable in scripts as well? |
Done. Also added a flag to disable it (and set it for spin boxes). |
…extEdit to show system character picker.
Thanks! |
Implements godotengine/godot-proposals#11468 for macOS. Edit: And Windows.
Screen.Recording.2025-01-02.at.13.23.18.mov