Android: Implement support for native dialog
#101061
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m4gr3d
requested changes
Jan 3, 2025
syntaxerror247
force-pushed
the
first-pr-2025
branch
2 times, most recently
from
f6c6f7d to
b5d624d
Compare
syntaxerror247
force-pushed
the
first-pr-2025
branch
from
b5d624d to
59d89a3
Compare
|
@m4gr3d I have applied the requested change. Please take a look and let me know if further adjustments are needed. |
m4gr3d
requested changes
Jan 5, 2025
platform/android/java/lib/src/org/godotengine/godot/utils/DialogUtils.kt
Show resolved
Hide resolved
platform/android/java/lib/src/org/godotengine/godot/utils/DialogUtils.kt
Show resolved
Hide resolved
platform/android/java/lib/src/org/godotengine/godot/utils/DialogUtils.kt
Outdated
Show resolved
Hide resolved
platform/android/java/lib/src/org/godotengine/godot/utils/DialogUtils.kt
Show resolved
Hide resolved
syntaxerror247
force-pushed
the
first-pr-2025
branch
from
59d89a3 to
69f0997
Compare
AThousandShips
approved these changes
Jan 13, 2025
platform/android/java/lib/src/org/godotengine/godot/utils/DialogUtils.kt
Outdated
Show resolved
Hide resolved
This adds support for DisplayServer::dialog_show() on Android, aligning it with the functionality already available on macOS and Windows.
syntaxerror247
force-pushed
the
first-pr-2025
branch
from
69f0997 to
cb9ee09
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for
DisplayServer::dialog_show()on Android, aligning it with the functionality already available on macOS and Windows.Note
It ensures the button layout adapts dynamically based on the screen size and button text length. Normally, there are two buttons per row, but if the button label gets longer, a new row is created for that button to fit the entire text. I also consider using three buttons per row, but two looked clearer to me.