Reorganize EditorNode menu options #101093
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KoBeWi
commented
Jan 3, 2025
Comment on lines
+162
to
+149
| FILE_UNDO, | ||
| FILE_REDO, |
There was a problem hiding this comment.
Renamed these 2 for consistency, but it does not look good. Though alternative is that they are the only 2 EDIT options.
There was a problem hiding this comment.
I think we can keep them as EDIT_UNDO / EDIT_REDO, that's clearer.
Edit: Ah wait I just understood, these are all entries in the "Scene" ("File"-like, menu). Then I guess the rename makes sense... but yeah it's not great.
FILE_QUIT also doesn't make too much sense so it's not too bad IMO.
akien-mga
approved these changes
Jan 7, 2025
|
Needs rebase. |
|
#101094 will conflict again, so I'll wait. |
KoBeWi
force-pushed
the
infinite_menu_entropy
branch
from
dcd2d1f to
d724a06
Compare
This comment was marked as resolved.
This comment was marked as resolved.
KoBeWi
force-pushed
the
infinite_menu_entropy
branch
from
d724a06 to
24eadaa
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inspired by #59442 (comment)
This PR moves around and renames various enum values from EditorNode. They are now organized by menu, listed in the order they appear, and consistently prefixed: FILE, PROJECT, EDITOR, HELP.
There were various "menu options" that weren't actually menu options, I changed them to methods. There were also some unused enum values, which I removed. I also moved some options used exclusively in scene tabs to EditorSceneTabs (they are still handled in EditorNode).
Some fake menu options were kept, because their logic is a bit tangled. We could rename them to use common prefix.