Add explicit error messages to Multimesh functions #101109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clayjohn
added
enhancement
topic:core
cherrypick:4.3
rburing
reviewed
Jan 4, 2025
JimmyCushnie
reviewed
Jan 4, 2025
clayjohn
force-pushed
the
multimesh-err-msg
branch
from
70dbf75 to
e615b40
Compare
|
Thank you @rburing and @JimmyCushnie! I addressed your comments and rebased on master |
rburing
requested changes
Feb 1, 2025
akien-mga
approved these changes
Feb 1, 2025
…rs easier to understand. Previously the RenderingServer errors filtered up to end users, but they are unclear and not helpful
akien-mga
force-pushed
the
multimesh-err-msg
branch
from
e615b40 to
e1af7b6
Compare
rburing
approved these changes
Feb 5, 2025
|
I'm happy with the updated language, thank you both! |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #100988
Previously the RenderingServer errors filtered up to end users, but they are unclear and not helpful. This PR adds explicit messages to make the errors easier to understand and to avoid even calling into the RenderingServer.