Fix gui overflow in Android editor #101234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akien-mga
reviewed
Jan 7, 2025
editor/animation_track_editor.cpp
Outdated
|
|
||
| bottom_hb->add_spacer(); | ||
| bottom_hf->add_child(memnew(Control)); // Add spacer. |
There was a problem hiding this comment.
Is that sufficient to get the behavior of a "spacer" like in BoxContainer?
There was a problem hiding this comment.
Sorry! I didn't realised add_spacer() also sets h_size_flags to SIZE_EXPAND_FILL. I have updated the code.
However, I think we should remove this spacer altogether.
This is without spacer, it leaves space in right.
This is with spacer (after i fixed this to get behaviour of BoxContainer)
With spacer it looks odd to have space in left.
syntaxerror247
force-pushed
the
out-of-screen
branch
from
c7db3b7 to
b0ae6f7
Compare
|
It looks ok but I don't have a small android screen to test. |
akien-mga
approved these changes
Jan 14, 2025
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the Android editor gui overflow issue caused by the packed bottom bar of the Animation Editor. The problem occurs when the bottom bar's content exceeds the available screen width, resulting in the interface extending off-screen.
It replaces the existing
HBoxContainerwithHFlowContainerto allow it to wrap when there isn't enough horizontal space.Closes #100688