Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows: Update export script's task to work even on battery power #101257

Merged

Conversation

SteffenBlake
Copy link
Contributor

Current Behavior

When generating an export profile targeting a remote windows machine over SSH, the script has this line on it:

$settings = New-ScheduledTaskSettingsSet

By default, a ScheduledTaskSettingsSet has the flags AllowStartIfOnBatteries and DontStopIfGoingOnBatteries set to false, which makes it so this line later on:

Start-ScheduledTask -TaskName godot_remote_debug

Silently fail to start the task if the target remote machine is on battery power. (Examples include a mobile device, tablet, laptop, etc)

Resolution

Updated the script to add the flags AllowStartIfOnBatteries and DontStopIfGoingOnBatteries setting them to true

@SteffenBlake SteffenBlake requested a review from a team as a code owner January 8, 2025 01:41
@bruvzg bruvzg added this to the 4.4 milestone Jan 8, 2025
@akien-mga akien-mga changed the title [BUGFIX] Update Windows Export Script's Task to Work Even on Battery Power Windows: Update export script's task to work even on battery power Jan 9, 2025
@akien-mga akien-mga merged commit a0de7d0 into godotengine:master Jan 9, 2025
20 checks passed
@akien-mga
Copy link
Member

Thanks! And congrats for your first merged Godot contribution 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants