GLTF: Don't write unused light properties #101271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaronfranke
force-pushed
the
gltf-directional-light-no-range
branch
from
db8adb8 to
01a26c5
Compare
akien-mga
approved these changes
Jan 13, 2025
fire
approved these changes
Jan 13, 2025
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/KhronosGroup/glTF/tree/main/extensions/2.0/Khronos/KHR_lights_punctual
When exporting a glTF light in Godot, it always writes several properties even when it does not need to. Per the above spec, most of these properties have default values, only
"type"is required. Also, we are not supposed to write the range when exporting directional lights, and glTF-Validator produces a note about the property being unused:Note: This only affects exporting glTF files, it doesn't break compatibility at all for importing.
I'm putting this on the 4.4 milestone because this is a very minor fix.