Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes
index
method 6x faster andgenerate_normals
3x faster.Tested in https://github.com/godotengine/godot-demo-projects/tree/master/3d/voxel.
In the
_generate_chunk_mesh
method of theChunk
class, I usedTime.get_ticks_usec
to get the elapsed time.Master:
Current PR:
It is worth noting that GDScript has now become the bottleneck, and if we were to do the same generation in C#, the total generation time would decrease many times.