Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix non-typed Dictionary keys displayed as <null> in the inspector. #101278

Merged
merged 1 commit into from
Jan 9, 2025

Conversation

bruvzg
Copy link
Member

@bruvzg bruvzg commented Jan 8, 2025

Fixes #101272, regression from #100512

@Sauermann
Copy link
Contributor

I can confirm, that this change resolves the <null> display problem for me.

Before #100512, the content of Array keys were directly visible (however in numeric form).
With this change, I need to click on each individual array element, to see its value, which seems to me like an inconvenient usability change. So finding a specific key now requires in the worst case a mouse-click on every key:
image

I'm not entirely sure, what should be considered a higher priority:

  • Easy access to Array keys
  • Visual representation of every Enum/Color/... key

@bruvzg
Copy link
Member Author

bruvzg commented Jan 8, 2025

I'm not entirely sure, what should be considered a higher priority:
Easy access to Array keys
Visual representation of every Enum/Color/... key

Not sure. Old mode (showing conductor string as label) was only usable with simple and small arrays, and it's still available as tooltip.

@Sauermann
Copy link
Contributor

and it's still available as tooltip

For me on Linux X11 with Editor Single Window Mode off, I don't get tooltips when hovering over the Array (size x) Dictionary key nodes.

@bruvzg
Copy link
Member Author

bruvzg commented Jan 9, 2025

Added #101331 code, but only applied to keys, so it should not change current value display and restore contents info for keys.

Screenshot 2025-01-09 at 11 35 03

@akien-mga akien-mga merged commit 1f675e6 into godotengine:master Jan 9, 2025
20 checks passed
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Keys of untyped dictionaries are no longer displayed in the Editor
3 participants