Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TextureProgressBar minimum size selection as maximum among all textures #101281

Closed
wants to merge 1 commit into from
Closed

TextureProgressBar minimum size selection as maximum among all textures #101281

wants to merge 1 commit into from

Conversation

arkology
Copy link
Contributor

@arkology arkology commented Jan 8, 2025

Closes #100693

Before After
Before After

@arkology arkology requested a review from a team as a code owner January 8, 2025 10:03
@AThousandShips AThousandShips added this to the 4.4 milestone Jan 8, 2025
@AThousandShips AThousandShips added cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release cherrypick:4.3 Considered for cherry-picking into a future 4.3.x release labels Jan 8, 2025
@arkology arkology force-pushed the texture-progress-minimum-size branch from df8a2f5 to 024461c Compare January 8, 2025 10:11
KoBeWi
KoBeWi reviewed Jan 22, 2025
View reviewed changes
scene/gui/texture_progress_bar.cpp Outdated
return over->get_size();
} else if (progress.is_valid()) {
return progress->get_size();
} else {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The else is unnecessary.

@arkology arkology closed this Jan 23, 2025
@arkology arkology force-pushed the texture-progress-minimum-size branch from 024461c to b2ec224 Compare January 23, 2025 05:58
@arkology arkology requested review from a team as code owners January 23, 2025 05:58
@arkology arkology requested a review from a team as a code owner January 23, 2025 05:58
@arkology
Copy link
Contributor Author

arkology commented Jan 23, 2025 •
edited
Loading

Ugh, I tried to use Github codespace (don't have access to PC right now) and messed up. I'm really sorry.
Will fix it ASAP.

@arkology
Copy link
Contributor Author

Github does not let me restore PR. Looks like skill issue. 😭
I have to create another PR.

@arkology arkology mentioned this pull request Jan 23, 2025
Merged
@AThousandShips AThousandShips added archived and removed cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release cherrypick:4.3 Considered for cherry-picking into a future 4.3.x release labels Jan 23, 2025
@AThousandShips AThousandShips removed this from the 4.4 milestone Jan 23, 2025
@AThousandShips AThousandShips removed request for a team January 23, 2025 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AThousandShips AThousandShips AThousandShips left review comments

@KoBeWi KoBeWi KoBeWi approved these changes

Assignees
No one assigned
Labels
archived bug topic:gui
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TextureProgressBar minimal size is prioritized to under -> over -> progress textures
3 participants
@arkology @KoBeWi @AThousandShips