Add String::ascii creator functions, to parse a char buffer as ASCII.
#101304
+41
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ivorforce
force-pushed
the
string-parse-ascii
branch
2 times, most recently
from
21364f4 to
0d288be
Compare
|
Tests were failing because of implicit conversions, but it should work fine on top of #101293. I have rebased the PR accordingly. |
bruvzg
approved these changes
Jan 9, 2025
kiroxas
approved these changes
Jan 9, 2025
AThousandShips
approved these changes
Jan 9, 2025
Ivorforce
force-pushed
the
string-parse-ascii
branch
2 times, most recently
from
4194cf0 to
5022418
Compare
|
#101293 has been merged, this is ready for a rebase! |
The function will log errors if any characters above value 127 are found.
Ivorforce
force-pushed
the
string-parse-ascii
branch
from
5022418 to
b6cfcde
Compare
|
Rebase complete! PR is looking much cleaner now =) |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The function will log errors if any characters above value 127 are found. This is most similar to
parse_latin1, butparse_latin1will silently and incorrectly parse values above 127 as 'extended latin set' characters, whenASCIIonly is expected. This would be especially incorrect if the input isutf8, because the string will silently have incorrect length and misinterpreted characters.As discussed in #101293 (comment), two functions in
plistare known to expectASCII-only strings, so they are used as an excuse to call the new function. It would be correct to callparse_asciion many other occasions (see #100641), but I do not have the broad knowledge to search out all these instances. Instead, the function is added here such that future contributions can call it to safely parseASCIIwhen it is expected.Requires and includes #101293 (because of implicit conversions).