Fix duplicated spec constant on SPIR-V reflection. #101343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RandomShaper
approved these changes
Jan 9, 2025
|
Thanks! |
RandomShaper
added
the
cherrypick:4.3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's a very minor error that affects the result of the SPIR-V reflection that ends up duplicating the first specialization constant in the structure.
The code intends to use -1 as the value for indicating the spec constant was not found in the existing array. However, the
ifchecks for> 0instead of>= 0, so the spec constant being found in the first available slot is never a valid possibility.This fixes any code that uses the result from the reflection from having duplicated spec constants.