When Char16String or CharString are constructed, call strlen in the header instead of the module.
#101349
+24
−45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… the header instead of the module. This allows the compiler to do it at compile time (if known then).
Ivorforce
force-pushed
the
string-sidekicks-constexpr-strlen
branch
from
21235ef to
781a92f
Compare
|
Rebased to use |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows the compiler to run
strlenat compile time (if known then), saving on runtime costs.This change brings the two classes on-par with
String's changes from recently (#100132). The change is less important forChar16StringandCharStringbecause it seems there are few callers of these functions in the codebase (if any at all, outside of tests).However, I'm still proposing the change to bring the two classes on-par with
Stringin this regard. When new changes toStringconstruction behavior are made, it will be easierCharStringandChar16Stringto follow along, to keep the classes consistent.