Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace Animation::_clear() with explicit .clear() calls. #101354

Merged
merged 1 commit into from
Jan 9, 2025
Merged

Replace Animation::_clear() with explicit .clear() calls. #101354

merged 1 commit into from
Jan 9, 2025

Conversation

Ivorforce
Copy link
Contributor

Code cleanup for a small oddity I came across.

This function has existed since Godot was made open source, and was since unchanged.

@Ivorforce Ivorforce requested a review from a team as a code owner January 9, 2025 15:46
@akien-mga akien-mga added this to the 4.4 milestone Jan 9, 2025
kiroxas
kiroxas approved these changes Jan 9, 2025
View reviewed changes
Copy link
Contributor

@kiroxas kiroxas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Negative linecount is good ! 👍

@akien-mga akien-mga merged commit 0257995 into godotengine:master Jan 9, 2025
20 checks passed
@akien-mga
Copy link
Member

Thanks!

@Ivorforce Ivorforce deleted the animation-clear-template branch January 9, 2025 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kiroxas kiroxas kiroxas approved these changes

@akien-mga akien-mga akien-mga approved these changes

Assignees
No one assigned
Labels
enhancement topic:animation topic:codestyle
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.
3 participants
@Ivorforce @akien-mga @kiroxas