Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Style: Enable clang-format's InsertBraces config #101355

Merged

Conversation

akien-mga
Copy link
Member

This was part of our style guide since we started using clang-format but the feature was only added in clang-format 15, and we hadn't noticed it yet.

This was part of our style guide since we started using clang-format
but the feature was only added in clang-format 15, and we hadn't
noticed it yet.
@akien-mga akien-mga added this to the 4.x milestone Jan 9, 2025
@akien-mga akien-mga requested a review from Repiteo January 9, 2025 15:48
@akien-mga akien-mga requested review from a team as code owners January 9, 2025 15:48
Copy link
Contributor

@Repiteo Repiteo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh wow, I just assumed this was already on

@Repiteo Repiteo modified the milestones: 4.x, 4.4 Jan 10, 2025
Copy link
Member

@AThousandShips AThousandShips left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@akien-mga akien-mga merged commit 139619c into godotengine:master Jan 10, 2025
20 checks passed
@akien-mga akien-mga deleted the style-clang-format-InsertBraces branch January 10, 2025 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants