Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Install apt dependencies directly, works around issue with awalsh128/cache-apt-pkgs-action #101363

Merged
merged 1 commit into from
Jan 9, 2025

Conversation

akien-mga
Copy link
Member

Works around awalsh128/cache-apt-pkgs-action#141, this shouldn't add too much to the build iteration time as it's a single package (it used to be several when we added this back then).

@akien-mga akien-mga requested a review from a team as a code owner January 9, 2025 18:58
@akien-mga akien-mga changed the title CI: Install apt dependencies directly, works around issue with awalsh128/cache-apt-pkgs-action CI: Install apt dependencies directly, works around issue with awalsh128/cache-apt-pkgs-action Jan 9, 2025
Copy link
Member

@AThousandShips AThousandShips left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to currently work as fast, so should be good at least as a stopgap solution

@akien-mga
Copy link
Member Author

akien-mga commented Jan 9, 2025

It is a bit slower, 9 s here vs 2 s with the action: https://github.com/godotengine/godot/actions/runs/12696343268/job/35390183038

But yeah we could merge and revert once the cache action gets fixed.

@akien-mga akien-mga added this to the 4.4 milestone Jan 9, 2025
@AThousandShips
Copy link
Member

That's true, meant on the order of magnitude

@akien-mga akien-mga merged commit 24d7451 into godotengine:master Jan 9, 2025
20 checks passed
@akien-mga akien-mga deleted the ci-apt-direct branch January 9, 2025 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants